[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/khtml/java
From:       LiuCougar <liucougar () gmail ! com>
Date:       2006-03-20 16:26:52
Message-ID: 955806780603200826v2783476enf7a436d50d12de41 () mail ! gmail ! com
[Download RAW message or body]

ok, if no one objects this, I will modify it

what about move the m_button into a d pointer?

On 3/20/06, Koos Vriezen <koos.vriezen@xs4all.nl> wrote:
> On Mon, Mar 20, 2006 at 12:48:47AM +0000, Heng Liu wrote:
> > SVN commit 520463 by liucougar:
> >
> > qt3support--
> >
> >  M  +31 -22    kjavaappletserver.cpp
> >  M  +2 -2      kjavaprocess.cpp
> >
> >
> > --- trunk/KDE/kdelibs/khtml/java/kjavaappletserver.cpp #520462:520463
> > @@ -862,7 +871,7 @@
> >
> >  void PermissionDialog::clicked()
> >  {
> > -    m_button = sender()->name();
> > +    m_button = sender()->objectName().toUtf8();
> >      static_cast<const QWidget*>(sender())->parentWidget()->close();
> >  }
> >
>
> I think it's better to make m_button a QString now.
>
> (Unfortunately I haven't found the courage to build the kde4 yet ..)
>
> Koos
>


--
"People's characters are strengthened through struggle against
difficulties; they are weakened by comfort."
- Old Chinese adage

[prev in list] [next in list] [prev in thread] [next in thread]