[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/rendering
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2006-03-18 3:08:31
Message-ID: 1142651311.126429.7189.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 519863 by ggarand:

null-check the widget before dereferencing...
fixes a crash on cnn.com Maksim just reported to me.

Stephan, if you have a chance to move the tag before packaging 
that would be great... :/

CCMAIL:coolo@kde.org




 M  +2 -0      render_object.cpp  


--- branches/KDE/3.5/kdelibs/khtml/rendering/render_object.cpp #519862:519863
@@ -2169,6 +2169,8 @@
     for (RenderObject* curr = firstChild(); curr; curr = curr->nextSibling()) {
         if ( curr->isWidget() && static_cast<RenderWidget*>(curr)->needsMask() ) {
             QWidget* w = static_cast<RenderWidget*>(curr)->widget();
+            if (!w)
+                return;
             RenderLayer* l = curr->enclosingStackingContext();
             QRegion r = l ? l->getMask() : QRegion();
             int x,y;
[prev in list] [next in list] [prev in thread] [next in thread]