[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kjsembed/kjsembed
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-03-14 9:17:46
Message-ID: 200603141017.47228.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Tuesday 14 March 2006 10:05, Thiago Macieira wrote:
> André Wöbbeking wrote:

> >Q_DECL_IMPORT is empty for UNIX/GCC. It would only work if
> > Q_DECL_IMPORT is equal to Q_DECL_EXPORT. Could this be changed in
> > Qt, Thiago or any other troll?
>
> Huh? Could you explain what change do you expect?
>
> It makes no sense to me, since it is supposed to work the way it is
> right now.
>
> Q_DECL_IMPORT is __declspec(dllimport) on Windows, ALWAYS
> Q_DECL_EXPORT is __declspec(dllexport) on Windows, ALWAYS
> Q_DECL_EXPORT is __attribute__((visibility("default")) if that's
> supported, empty otherwise
> Q_DECL_IMPORT is empty on non-Windows, ALWAYS
>
> So, what's the issue?

If Q_DECL_IMPORT would be equal to Q_DECL_EXPORT for UNIX/GCC we could 
simply write

> # if (defined(KJSEMBED_DLL) && defined(KJSEMBED_MAKE_DLL)) ||
> defined(MAKE_KJSEMBED_LIB)
> #  define KJSEMBED_EXPORT Q_DECL_EXPORT
> # else
> #  define KJSEMBED_EXPORT Q_DECL_IMPORT
> # endif

There would be no need for plattform ifdefs. Less errorprone and more 
readable.

[prev in list] [next in list] [prev in thread] [next in thread]