[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/html
From:       Maks Orlovich <maksim () kde ! org>
Date:       2006-02-19 15:50:59
Message-ID: 1140364259.458350.19279.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 511343 by orlovich:

Match IE behavior on parsing of malformed textarea cols/rows
(Coincidentally, mozilla manages to have different behavior between the two)
BUG:122287


 M  +8 -2      html_formimpl.cpp  


--- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #511342:511343
@@ -2638,12 +2638,18 @@
     switch(attr->id())
     {
     case ATTR_ROWS:
-        m_rows = attr->val() ? attr->val()->toInt() : 3;
+        m_rows = 0;
+        if (attr->val())
+            m_rows = DOMString(attr->val()).string().toInt();
+        if (!m_rows) m_rows = 2;
         if (renderer())
             renderer()->setNeedsLayoutAndMinMaxRecalc();
         break;
     case ATTR_COLS:
-        m_cols = attr->val() ? attr->val()->toInt() : 60;
+        m_cols = 0;
+        if (attr->val())
+            m_cols = DOMString(attr->val()).string().toInt();
+        if (!m_cols) m_cols = 20;
         if (renderer())
             renderer()->setNeedsLayoutAndMinMaxRecalc();
         break;
[prev in list] [next in list] [prev in thread] [next in thread]