[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/khtml/java
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2006-02-04 21:35:57
Message-ID: 20060204213557.GB78210 () xs4all ! nl
[Download RAW message or body]

On Sat, Feb 04, 2006 at 09:49:18PM +0100, Alexander Neundorf wrote:
> On Saturday 04 February 2006 21:34, Koos Vriezen wrote:
> > On Sat, Feb 04, 2006 at 08:09:02PM +0000, Alexander Neundorf wrote:
> > > SVN commit 505761 by neundorf:
> > >
> > > compile fix e.g. for gcc 3.3, maybe also 3.4
> > >
> > > --- trunk/KDE/kdelibs/khtml/java/kjavaappletviewer.cpp #505760:505761
> > > @@ -355,6 +355,12 @@
> > >      connect (applet, SIGNAL(jsEvent (const QStringList &)),
> > > m_liveconnect, SLOT(jsEvent (const QStringList &))); }
> > >
> > > +CoverWidget * KJavaAppletViewer::view () const
> > > +{
> > > +   return m_view;
> > > +}
> > > +
> > > +
> > >  bool KJavaAppletViewer::eventFilter (QObject *o, QEvent *e) {
> > >      if (m_liveconnect->jsSessions () > 0) {
> > >          switch (e->type()) {
> > > --- trunk/KDE/kdelibs/khtml/java/kjavaappletviewer.h #505760:505761
> > > @@ -85,7 +85,7 @@
> > >      KJavaAppletViewer (QWidget * wparent, const char * wname,
> > >                QObject * parent, const char * name, const QStringList
> > > &args); ~KJavaAppletViewer ();
> > > -    CoverWidget * view () const { return m_view;}
> > > +    CoverWidget * view () const;
> > >      static KAboutData* createAboutData ();
> > >
> > >      KJavaAppletViewerBrowserExtension * browserextension() const
> > > _______________________________________________
> >
> > I don't get it, what's wrong with this?
> >
> > Koos
> 
> See here (4th february, at the bottom, the one error on machine horizon):
> http://public.kitware.com/dashboard.php?name=kde
> 
> Qt/qpointer.h:56: error: invalid static_cast from type `QObject*' to type 
> `CoverWidget*' /.../kdelibs/khtml/java/kjavaappletviewer.cpp: In   
> constructor
> 
> On my machine I had the same problem with gcc 3.3.6, I don't know which gcc 
> version on this box (horizon, mig tbe Laurent Montel) runs.

I think the problem is that CoverWidget is only declared as forward
class and qpointer.h:56
  return static_cast<T*>(const_cast<QObject*>(o));
I can imagine this will fail w/ all compilers.
I guess the CoverWidget class declarion should be visible to
the compiler when used w/ QPointer, so probably move it to the .h
would solve this.

Thanks,

Koos
[prev in list] [next in list] [prev in thread] [next in thread]