[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kspread
From:       Robert Knight <robertknight () gmail ! com>
Date:       2006-01-31 21:17:43
Message-ID: 1138742263.288697.27635.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 504357 by knight:

Fix highlighted ranges sometimes not updating properly

 M  +8 -1      kspread_editors.cc  
 M  +7 -1      kspread_editors.h  


--- trunk/koffice/kspread/kspread_editors.cc #504356:504357
@@ -106,7 +106,7 @@
 
   // save the old ones to identify range changes
   Tokens oldTokens = d->tokens;
-  d->rangeChanged = false;
+ // d->rangeChanged = false;
 
   // interpret the text as formula
   // we accept invalid/incomplete formulas
@@ -270,6 +270,11 @@
   return d->rangeChanged;
 }
 
+void FormulaEditorHighlighter::resetRangeChanged()
+{
+    d->rangeChanged=false;
+}
+
 } // namespace KSpread
 
 
@@ -723,6 +728,8 @@
   {
     if (rangeCountDiff != 0 || d->highlighter->rangeChanged())
     {
+      d->highlighter->resetRangeChanged();
+      
       d->canvas->doc()->emitBeginOperation();
       setUpdateChoice(false);
 
--- trunk/koffice/kspread/kspread_editors.h #504356:504357
@@ -78,11 +78,17 @@
    */
   uint rangeCount() const;
   /**
-   *
+   * Returns true if any of the ranges or cells in the formula have changed since the 
+   * last call to @ref FormulaEditorHighlighter::rangeChanged() 
    */
   bool rangeChanged() const;
   
+  /**
+   * Sets the highlighter's range changed flag to false.
+   */
+  void resetRangeChanged();
   
+  
 
 protected:
   /**
[prev in list] [next in list] [prev in thread] [next in thread]