[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2006-01-30 21:07:49
Message-ID: 51914.128.84.98.74.1138655269.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

> On Monday 30 January 2006 12:05, David Faure wrote:
>> On Saturday 28 January 2006 23:04, Benjamin Reed wrote:
>> > SVN commit 503366 by reed:
>> >
>> > work around some kjs stuff that assumes __APPLE__ == WEBKIT, also fix
>> > definitions for QT_AND_KDECORE_LIBS to get -L and -F
>> >
>> >  M  +3 -3      cmake/modules/FindKDE4.cmake
>> >  M  +1 -1      kjs/internal.h
>>
>> A better fix is probably to s/__APPLE__/APPLE_CHANGES/, no?
>
>   No, I will clobber those with my next commit again.

Please don't, I am almost done with doing a proper merge. And most of the
removal of those is broken. For example, do you want us to require a fork
of libPCRE?


> The better fix is to
> determine what is specific to webkit (there shouldn't be much) and wrap it
> with something that says so.  -- And do it in webkit too.

Right, that's what APPLE_CHANGES means :-)




[prev in list] [next in list] [prev in thread] [next in thread]