[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kioslave [POSSIBLY UNSAFE]
From:       "Christian Ehrlicher" <Ch.Ehrlicher () gmx ! de>
Date:       2006-01-23 13:04:31
Message-ID: 25154.1138021471 () www019 ! gmx ! net
[Download RAW message or body]

> --- Ursprüngliche Nachricht ---
> Von: Lubos Lunak <l.lunak@suse.cz>
> An: kde-commits@kde.org
> Kopie: Christian Ehrlicher <Ch.Ehrlicher@gmx.de>
> Betreff: Re: KDE/kdelibs/kioslave [POSSIBLY UNSAFE]
> Datum: Mon, 23 Jan 2006 13:45:10 +0100
> 
> On Sunday 22 January 2006 19:26, Christian Ehrlicher wrote:
> > SVN commit 501368 by chehrlic:
> >
> > fix compile and link on win32
> >
> >  M  +4 -1      file/SConscript
> >  M  +2 -3      file/file.cc
> >  M  +4 -1      ftp/SConscript
> >  M  +6 -4      ftp/ftp.cc   [POSSIBLY UNSAFE: scanf]
> >  M  +4 -1      http/SConscript
> >  M  +4 -1      metainfo/SConscript
> >  M  +0 -5      metainfo/metainfo.cpp
> >
> 
> > --- trunk/KDE/kdelibs/kioslave/metainfo/metainfo.cpp #501367:501368
> > @@ -35,11 +35,6 @@
> >
> >  using namespace KIO;
> >
> > -extern "C"
> > -{
> > -    KDE_EXPORT int kdemain(int argc, char **argv);
> > -}
> > -
> >  int kdemain(int argc, char **argv)
> >  {
> >      KAboutData about("kio_metainfo", "kio_metainfo", "");
> 
>  I guess these changes actually break it. Why do need to remove making the
> entry point extern "C" and exported?
> 
Because this is a redefinition on windows (it's defined in
kdelibs/win/include/kdelibs_global_win.h) and it looked like a leftover from
the first attemps of Jaroslaw Staniek to compile kdelibs on windows.

But why do you need to export the main function? It doesn't make sense for
me... 

Christian

-- 
Lust, ein paar Euro nebenbei zu verdienen? Ohne Kosten, ohne Risiko!
Satte Provisionen für GMX Partner: http://www.gmx.net/de/go/partner
[prev in list] [next in list] [prev in thread] [next in thread]