[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kdelibs-phonon/phonon/ui
From:       Matthias Kretz <kretz () kde ! org>
Date:       2006-01-18 22:30:05
Message-ID: 1137623405.150231.15446.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 499867 by mkretz:

testing rocks, forgot to call break in a switch


 M  +2 -0      seekslider.cpp  
 M  +2 -0      tests/Makefile.am  
 M  +8 -3      tests/seekslider.cpp  
 M  +1 -1      tests/seekslider.h  


--- branches/work/kdelibs-phonon/phonon/ui/seekslider.cpp #499866:499867
@@ -96,11 +96,13 @@
 		case Phonon::BufferingState:
 		case Phonon::PlayingState:
 			d->slider->setEnabled( true );
+			break;
 		case Phonon::PausedState:
 		case Phonon::StoppedState:
 		case Phonon::LoadingState:
 		case Phonon::ErrorState:
 			d->slider->setEnabled( false );
+			break;
 	}
 }
 
--- branches/work/kdelibs-phonon/phonon/ui/tests/Makefile.am #499866:499867
@@ -24,3 +24,5 @@
 check_PROGRAMS = seekslider
 
 seekslider_SOURCES = seekslider.cpp
+
+TESTS = seekslider
--- branches/work/kdelibs-phonon/phonon/ui/tests/seekslider.cpp #499866:499867
@@ -42,13 +42,18 @@
 	QVERIFY( !qslider->isEnabled() );
 }
 
-void SeekSliderTest::testErrorMedia()
+void SeekSliderTest::testMedia()
 {
 	MediaObject media( this );
-	media.setUrl( "/dev/null" );
-	QVERIFY( media.state() == Phonon::ErrorState );
+	QVERIFY( media.state() == Phonon::LoadingState );
+	media.setUrl( "/home/mkretz/Musik Abend 2 - Flora.wav" );
 	ss->setMediaProducer( &media );
 	QVERIFY( !qslider->isEnabled() );
+	media.play();
+	if( media.state() == Phonon::PlayingState )
+		QVERIFY( qslider->isEnabled() );
+	else
+		QVERIFY( !qslider->isEnabled() );
 }
 
 void SeekSliderTest::cleanupTestCase()
--- branches/work/kdelibs-phonon/phonon/ui/tests/seekslider.h #499866:499867
@@ -36,7 +36,7 @@
 	private slots:
 		void initTestCase();
 		void testEnabled();
-		void testErrorMedia();
+		void testMedia();
 		void cleanupTestCase();
 	private:
 		Phonon::Ui::SeekSlider* ss;
[prev in list] [next in list] [prev in thread] [next in thread]