[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kutils
From:       André_Wöbbeking <Woebbeking () onlinehome ! de>
Date:       2006-01-09 21:18:13
Message-ID: 200601092218.13975.Woebbeking () onlinehome ! de
[Download RAW message or body]

On Monday 09 January 2006 20:52, David Faure wrote:
> SVN commit 496117 by dfaure:
>
> Fix bugs shown by unit tests for KFind, by
> - using QList<Data> instead of QVector<Data *>
> - reverting the qt-4.0 workaround
> - adapting to the changed QString::lastIndexOf behavior better
> (the qt-4.1 fix only works for empty patterns, but the problem
> remained for non-empty ones)
>
>
>  M  +1 -1      Makefile.am
>  M  +24 -17    kfind.cpp
>
>
> --- trunk/KDE/kdelibs/kutils/kfind.cpp #496116:496117
> @@ -471,6 +473,11 @@
>          return find(text, regExp, index, options, matchedLength);
>      }
>
> +    // In Qt4 QString("aaaaaa").lastIndexOf("a",6) returns -1; we
> need +    // to start at text.length() - pattern.length() to give a
> valid index to QString. +    if (options & KFind::FindBackwards)
> +        index = QMIN( text.length() - pattern.length(), index );

where did you find that QMIN?
[prev in list] [next in list] [prev in thread] [next in thread]