[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs
From:       Michael Brade <brade () kde ! org>
Date:       2006-01-03 17:15:57
Message-ID: 200601031816.06262.brade () kde ! org
[Download RAW message or body]


On Tuesday 03 January 2006 13:42, David Faure wrote:
> SVN commit 493829 by dfaure:
>
> -typedef Q3PtrList<KFileItem> KFileItemList;
> +class KFileItemList : public QList<KFileItem *>
>
> + simplifying some code by adding some convenience methods to
> KFileItemList.
nice, so we could even add some more if needed, like clearing the list with 
autoDelete ;-)

>  M  +66 -67    kio/kio/kdirlister.cpp
@@ -1241,7 +1236,7 @@

     delete dir->rootItem;
     dir->rootItem = 0;
-    dir->lstItems->clear();
+    dir->lstItems.clear();
     dir->redirect( newUrl );
     itemsInUse.insert( newUrl.url(), dir );
     urlsCurrentlyListed.insert( newUrl.url(), listers );

I think you forgot a qDeleteAll( dir->lstItems ) here.

And a probably dumb question since I guess you had a reason for it: why these 
changes that remove the consts, e.g.:
-void KDirLister::addNewItem( const KFileItem *item )
+void KDirLister::addNewItem( KFileItem *item )
?

-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
   °--web: http://www.kde.org/people/michaelb.html

KDE 4: Beyond Your Expectations

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]