[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/kviewshell/plugins/dvi [POSSIBLY UNSAFE]
From:       Angus Leeming <leeming () lyx ! org>
Date:       2005-12-15 23:08:54
Message-ID: 1134688134.800780.27598.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 488807 by leeming:

Finish off the previous commit (sorry 'bout that): set setUseShell if quoting args.


 M  +3 -1      dviRenderer.cpp   [POSSIBLY UNSAFE: setUseShell]
 M  +6 -2      dviRenderer_export.cpp   [POSSIBLY UNSAFE: setUseShell]


--- trunk/KDE/kdegraphics/kviewshell/plugins/dvi/dviRenderer.cpp #488806:488807
@@ -744,7 +744,8 @@
   }
 
   // Set up a shell process with the editor command.
-  proc = new KProcess();
+  proc = new KProcess;
+  
   if (proc == 0) {
     kdError(kvs::dvi) << "Could not allocate ShellProcess for the editor command." << endl;
     return;
@@ -766,6 +767,7 @@
 
 
   proc->clearArguments();
+  proc->setUseShell(true, getenv("SHELL"));
   *proc << command;
   proc->closeStdin();
   if (proc->start(KProcess::NotifyOnExit, KProcess::AllOutput) == false) {
--- trunk/KDE/kdegraphics/kviewshell/plugins/dvi/dviRenderer_export.cpp #488806:488807
@@ -120,7 +120,7 @@
     qApp->connect(progress, SIGNAL(finished()), this, SLOT(abortExternalProgramm()));
   }
 
-  proc = new KProcess();
+  proc = new KProcess;
   if (proc == 0) {
     kdError(kvs::dvi) << "Could not allocate ShellProcess for the dvipdfm command." << endl;
     return;
@@ -137,6 +137,8 @@
   info->clear(i18n("Export: %1 to PDF").arg(KProcess::quote(dviFile->filename)));
 
   proc->clearArguments();
+  proc->setUseShell(true, getenv("SHELL"));
+
   finfo.setFile(dviFile->filename);
   *proc << QString("cd %1; dvipdfm").arg(KProcess::quote(finfo.dirPath(true)));
   *proc << QString("-o %1").arg(KProcess::quote(fileName));
@@ -286,7 +288,7 @@
   }
 
   // Allocate and initialize the shell process.
-  proc = new KProcess();
+  proc = new KProcess;
   if (proc == 0) {
     kdError(kvs::dvi) << "Could not allocate ShellProcess for the dvips command." << endl;
     return;
@@ -301,6 +303,8 @@
   info->clear(i18n("Export: %1 to PostScript").arg(KProcess::quote(dviFile->filename)));
 
   proc->clearArguments();
+  proc->setUseShell(true, getenv("SHELL"));
+
   QFileInfo finfo(dviFile->filename);
   *proc << QString("cd %1; dvips").arg(KProcess::quote(finfo.dirPath(true)));
   if (printer == 0)
[prev in list] [next in list] [prev in thread] [next in thread]