--nextPart1561600.8ifoiU0qPu
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Just found this while skimming through kde-commits:

> SVN commit 479280 by aseigo:
>
> in kicker when we have items in the menu that use dirlister, they get
> deleted at a point when the dirlister has had its holders removed so
> calls to forgetDirs fail.
Can you please explain a little better? You SHOULD NOT (!!) delete your ite=
ms=20
yourself, the KDirListerCache does it for you!

> so instead of using ASSERTS we just check for=20
> the pointers instead of assert()ing them and voila! the kdirlister crash =
is
> gone! huzzah! BUG:113242
Why didn't you tell me about this and/or send me some debugging output?? Th=
e=20
patch is completely wrong!!! And will break in cases that will be VERY hard=
=20
to debug now. Don't you think there's a reason for an assert? Rule of thumb=
:=20
*never* remove an assert in KDirListerCache, some might be redundant, but=20
none of them is worng! (I didn't even see the patch on kde-core-devel?)

Basically what can happen now is that other KDirListers are still using the=
=20
items of that directory and you delete it anyway. That will crash. An updat=
e=20
might be running while you are removing the dir the update is running on=20
without stopping the update -> crash. There's probably a lot more=20
possibilities that can go wrong now, so please let's fix this correctly and=
=20
revert this patch before KDE 3.5.

PS: the worst thing is that I only found out now, three days before my last=
=20
but one diploma examination :-(

=2D-=20
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  =C2=B0--web: http://www.kde.org/people/michaelb.html

KDE 3: The Next Generation in Desktop Experience

--nextPart1561600.8ifoiU0qPu
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBDgFSZdK2tAWD5bo0RAqJ8AKD2vVVdt2A6qNAfb2JR5SWq4AwAZQCgiIAz
Zem4g/nym+fT/4gRMn9Ea7E=
=H6u+
-----END PGP SIGNATURE-----

--nextPart1561600.8ifoiU0qPu--