[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src [BROKEN EMAIL]
From:       Ian Monroe <ian () monroe ! nu>
Date:       2005-11-08 18:48:11
Message-ID: f680fec50511081048p14a65d45q2e170c5a8c066e11 () mail ! gmail ! com
[Download RAW message or body]

Probably doesn't make much difference, but we use the debug() function
available in "debug.h".

On 11/8/05, Gav Wood <gav@indigoarchive.net> wrote:
> SVN commit 478984 by gav:
> 
> Extra debug stuff for help diagnosing problems.
> Fix for the playlist header widths which were fscking themselves.
> 
> 
> M  +12 -1     moodbar.cpp
> M  +1 -1      playlist.cpp
> M  +2 -1      playlistwindow.cpp
> 
> 
> --- trunk/extragear/multimedia/amarok/src/moodbar.cpp #478983:478984
> @@ -84,6 +84,7 @@
> if(!testopen.open(IO_ReadOnly)) return false;
> }
> #ifdef HAVE_EXSCALIBAR
> +       qDebug("MakeMood: Creating mood with Exscalibar. Hold onto your hats...");
> ProcessorGroup g;
> ProcessorFactory::create("Player")->init("P", g, Properties("Filename", \
> theFilename)); SubProcessorFactory::createDom("Mean")->init("M", g);
> @@ -101,11 +102,17 @@
> (*W) >>= (*N);
> (*N) >>= g["D"];
> if(g.go())
> -       {       g["D"].waitUntilDone();
> +       {
> +               qDebug("MakeMood: Processing...");
> +               g["D"].waitUntilDone();
> +               qDebug("MakeMood: Done processing. Cleaning up...");
> g.stop();
> }
> +       else
> +               qDebug("MakeMood: Exscalibar reports a problem analysing the \
> song."); g.disconnectAll();
> g.deleteAll();
> +       qDebug("MakeMood: All tidied up.");
> if(!QFile::exists(theMoodName)) return false;
> QFile mood(theMoodName);
> if(!mood.open(IO_ReadOnly)) return false;
> @@ -123,6 +130,7 @@
> 
> QValueVector<QColor> amaroK::readMood(const QString path)
> {
> +       qDebug("MakeMood: Reading mood file %s...", path.latin1());
> QString filebase = path;
> QValueVector<QColor> theArray;
> filebase.truncate(filebase.findRev('.'));
> @@ -137,6 +145,7 @@
> if(QFile::exists(homefilebase)) mood.setName(homefilebase);
> if(mood.name() != "" && mood.open(IO_ReadOnly))
> {
> +               qDebug("ReadMood: File opened. Proceeding to read contents...");
> int r, g, b, s = mood.size() / 3;
> int huedist[360], total = 0, mx = 0;
> for(int i = 0; i < 360; i++) huedist[i] = 0;
> @@ -155,6 +164,7 @@
> }
> if(AmarokConfig::makeMoodier())
> {
> +                       qDebug("ReadMood: Making moodier!");
> //                     int threshold =
> //                     int rangeStart AmarokConfig::redShades()
> for(int i = 0; i < 360; i++) if(huedist[i] > s / 360 * 5) total++;
> @@ -171,5 +181,6 @@
> }
> }
> }
> +       qDebug("ReadMood: All done.");
> return theArray;
> }
> --- trunk/extragear/multimedia/amarok/src/playlist.cpp #478983:478984
> @@ -290,7 +290,7 @@
> addColumn( i18n( "Score"      ),   0 );
> addColumn( i18n( "Type"       ),   0 );
> addColumn( i18n( "Playcount"  ),   0 );
> -    addColumn( i18n( "Moodbar"    ),  AmarokConfig::showMoodbar() ? 100 : 0 );
> +    addColumn( i18n( "Moodbar"    ),  AmarokConfig::showMoodbar() ? 40 : 0 );
> 
> setRenameable( 0, false ); //TODO allow renaming of the filename
> setRenameable( 1 );
> --- trunk/extragear/multimedia/amarok/src/playlistwindow.cpp #478983:478984
> @@ -469,7 +469,8 @@
> ContextBrowser::instance()->unsetFont();
> break;
> }
> -    Playlist::instance()->setColumnWidth( PlaylistItem::Moodbar, \
> AmarokConfig::showMoodbar() ? 100 : 0 ); +    if( AmarokConfig::showMoodbar() != \
> (Playlist::instance()->columnWidth( PlaylistItem::Moodbar ) != 0) ) +        \
> Playlist::instance()->setColumnWidth( PlaylistItem::Moodbar, \
> AmarokConfig::showMoodbar() ? 100 : 0 ); }
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]