[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: playground/base/kat
From:       Frans Englich <frans.englich () telia ! com>
Date:       2005-11-07 14:34:36
Message-ID: 200511071434.36464.frans.englich () telia ! com
[Download RAW message or body]

On Saturday 05 November 2005 02:25, Thiago Macieira wrote:
> Jos van den Oever wrote:
[...]

> 2) use quotes around the var assignments. I.e.:
> TMP_CXXFLAGS="$CXXFLAGS"
> CXXFLAGS="$CXXFLAGS $USE_EXCEPTIONS"
> KDE_CHECK_...

Ok, I can perhaps learn from this. Is the following correct?

Index: Makefile.global
===================================================================
--- Makefile.global     (revision 478662)
+++ Makefile.global     (working copy)
@@ -1 +1 @@
-KDE_CXXFLAGS = $(USE_EXCEPTIONS) -DQT_CLEAN_NAMESPACE -DQT_NO_COMPAT 
-DQT_NO_CAST_ASCII -DQT_NO_ASCII_CAST -DQT3_SUPPORT
+KDE_CXXFLAGS = "$(USE_EXCEPTIONS) -DQT_CLEAN_NAMESPACE -DQT_NO_COMPAT 
-DQT_NO_CAST_ASCII -DQT_NO_ASCII_CAST -DQT3_SUPPORT"


What is the advantage? What problem is avoided?


Cheers,

		Frans
[prev in list] [next in list] [prev in thread] [next in thread]