[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2005-10-14 11:53:04
Message-ID: 1129290784.621368.9323.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 470580 by wildfox:

Fix test/data/dynupdate/containerChange.svg / groupchanges.svg / groupchangescss.svg etc..
Rob investigated that the uncommented line in SVGGElementImpl causes the problem,
I just cleaned up the code a bit - good job Rob (hey that's a rhyme!)


 M  +8 -2      kdom/core/NodeImpl.cpp  
 M  +0 -2      ksvg2/svg/SVGGElementImpl.cpp  


--- trunk/kdenonbeta/kdom/core/NodeImpl.cpp #470579:470580
@@ -1241,10 +1241,14 @@
         return;
 
     m_changed = b;
+
     if(deep)
+    {
         for(NodeImpl *n = firstChild(); n != 0; n = n->nextSibling())
             n->setChanged(b, deep);
-    else if(b)
+    }
+
+    if(b)
     {
         NodeImpl *p = parentNode();
         while(p)
@@ -1252,7 +1256,9 @@
             p->setHasChangedChild(true);
             p = p->parentNode();
         }
-        //ownerDocument()->setDocumentChanged();
+
+        // TODO: find out who needs this logic!
+        // ownerDocument()->setDocumentChanged();
     }
 }
 
--- trunk/kdenonbeta/ksvg2/svg/SVGGElementImpl.cpp #470579:470580
@@ -49,9 +49,7 @@
 
 void SVGGElementImpl::setChanged(bool b, bool)
 {
-    // FIXME: this is waaay to slow & wrong!
     KDOM::NodeImpl::setChanged(b, true);
-    //KDOM::NodeImpl::setChanged(b, false);
 }
 
 KCanvasItem *SVGGElementImpl::createCanvasItem(KCanvas *canvas, KRenderingStyle *style) const
[prev in list] [next in list] [prev in thread] [next in thread]