[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/kresources/egroupware
From:       Frank Osterfeld <frank.osterfeld () gmx ! de>
Date:       2005-10-02 4:29:07
Message-ID: 200510020629.16130.frank.osterfeld () gmx ! de
[Download RAW message or body]


Why unconditionally? There is a "case QVariant::String:" above that line, 
isn't there ? So this return is executed if and only if the QVariant holds a 
String. Right now it would continue at "case QVariant::Int:" (as there is no 
break nor return), try to cast the QVariant to an int, and fail.

On Sunday 02 October 2005 05:18, you wrote:
> SVN commit 466260 by tstaerk:
>
> do not return unconditionally
> CCMAIL:kloecker@kde.org
> CCMAIL:frank.osterfeld@kdemail.net
>
>
>  M  +1 -1      xmlrpciface.cpp
>
>
> --- trunk/KDE/kdepim/kresources/egroupware/xmlrpciface.cpp #466259:466260
> @@ -204,7 +204,7 @@
>        case QVariant::String:
>  #warning Port me!
>        //case QVariant::CString:
> -      return "<value><string>" + arg.toString() + "</string></value>\r\n";
> +      //return "<value><string>" + arg.toString() +
> "</string></value>\r\n"; case QVariant::Int:
>        return "<value><int>" + QString::number( arg.toInt() ) +
> "</int></value>\r\n"; case QVariant::Double:


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]