[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui
From:       Joseph Wenninger <jowenn () kde ! org>
Date:       2005-09-29 19:20:28
Message-ID: 200509292120.28533.jowenn () kde ! org
[Download RAW message or body]

Hi !

Am Donnerstag, 29. September 2005 19:49 schrieb David Faure:
> SVN commit 465414 by dfaure:
>
> Fix typo.
>
> Shouldn't setInMimeData be addToMimeData for consistency with KURL and
> KBookmark? Or we could use setInMimeData there, I don't mind, it should
> just be consistent... 

I'm all for consistency. 

> ('set' has the advantage that it makes clear that you 
> can't call it twice).

That was the reasoning behind calling it "set". addToMimeData sounds like put 
one color into it, add another one, ....
I have to admit, I didn't look the kurl::list::addTo... implementation. Does 
it do a simple one time set operation  too or is it possible to be called 
more than once to add additional urls to the existing list ? If it is a one 
time call I would vote for "set" there too.

Kind regards
Joseph Wenninger
[prev in list] [next in list] [prev in thread] [next in thread]