[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.4/kdelibs/kdeui
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2005-09-28 14:49:47
Message-ID: 1127918987.071626.2012.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 464903 by aseigo:

don't tooltip by default on kpushbuttons. prevents problems with
kdesktop and looks nicer anyways
BUG:113489


 M  +12 -2     kpushbutton.cpp  


--- branches/KDE/3.4/kdelibs/kdeui/kpushbutton.cpp #464902:464903
@@ -100,7 +100,12 @@
 
     setSizePolicy( QSizePolicy( QSizePolicy::Minimum, QSizePolicy::Minimum ) );
 
-    QToolTip::add( this, item.toolTip() );
+    // do not add a tooltip here by default as it results in an event filter
+    // being applied to the QApplication which interferes with some specific
+    // cases such as kdesktop's event filter on the root window. besides, most
+    // of these tooltips are compeletely redundant against the text of the
+    // button and look completely inapropriate
+    // QToolTip::add( this, item.toolTip() );
 
     QWhatsThis::add( this, item.whatsThis() );
 
@@ -125,8 +130,13 @@
     // set the GUI items text or check the state of the icon set
     QPushButton::setText( d->item.text() );
     setIconSet( d->item.iconSet() );
-    QToolTip::add( this, d->item.toolTip() ); 
     QWhatsThis::add( this, d->item.whatsThis() );
+    // do not add a tooltip here by default as it results in an event filter
+    // being applied to the QApplication which interferes with some specific
+    // cases such as kdesktop's event filter on the root window. besides, most
+    // of these tooltips are compeletely redundant against the text of the
+    // button and look completely inapropriate
+    // QToolTip::add( this, d->item.toolTip() ); 
 }
 
 void KPushButton::setGuiItem( KStdGuiItem::StdItem item )
[prev in list] [next in list] [prev in thread] [next in thread]