[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdebase/kioslave/media
From:       Thiago Macieira <thiago () kde ! org>
Date:       2005-09-26 20:44:38
Message-ID: 200509261744.38654.thiago () kde ! org
[Download RAW message or body]


Mario Teijeiro Otero wrote:
>+   if [ test $hal_inc != FOUND ] || [ test $hal_lib != FOUND ]; then

That isn't right. /usr/bin/[ and /usr/bin/test are the same program.

You should write:
  if test "$hal_inc" != FOUND -o "$hal_lib" != FOUND; then
(or replace the -o with || test; I hate writing these tests in sh)

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]