[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok
From:       Nadeem Hasan <nhasan () nadmm ! com>
Date:       2005-09-25 23:00:16
Message-ID: 200509251900.30519.nhasan () nadmm ! com
[Download RAW message or body]


On Sunday 25 September 2005 18:20, Ian Monroe wrote:
> Why? KDialogBase seems mostly concerned about layout and such, this
> window is nothing but an image.
>
> On 9/25/05, Nadeem Hasan <nhasan@nadmm.com> wrote:
> > On Tuesday 20 September 2005 19:35, Alexandre Pereira de Oliveira wrote:
> > > SVN commit 462403 by aoliveira:
> > > +CoverViewDialog::CoverViewDialog(const QString& artist, const QString&
> > > album, QWidget *parent) +    : QDialog(parent, 0, false,
> > > WDestructiveClose
> > >
> > > | WType_TopLevel | WNoAutoErase) +    ,
> >
> > Please use KDialogBase instead of QDialog whenever possible (which is
> > almost every time).

Does it have any buttons like Ok/Cancel? If yes then better use KDialogBase. 
If its just showing a pixmap and nothing else then nevermind.

-- 
Nadeem Hasan - nhasan (@) nadmm.com - nhasan (@) kde.org
GPG Fingerprint: 7141 0B1C 9CAF 624D 307F F8EF 6C0C 753E DD3A 0F53

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]