[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/3.5/kdebase/kdesktop
From:       Martijn Klingens <klingens () kde ! org>
Date:       2005-09-23 9:34:22
Message-ID: 200509231134.22446.klingens () kde ! org
[Download RAW message or body]

On Friday 23 September 2005 11:18, André Wöbbeking wrote:
> You should use isEmpty() instead of isNull().

Arguably, yes. At least on Qt 4...

> AFAIK many KStdGuiItem already have tooltips, so your fix won't help.

I suggested to Aaron to set the tooltip to empty as in

  KGuiItem foo = KStdGuiItem::bla();
  foo.setToolTip( QString::null );
  pushButton->setGuiItem( foo );

That will work. Setting an empty tooltip is still a bit of bandaid, but at 
least less ugly than converting to QPushButton. (Does the QPushButton code 
handle the case of switching the icons-on-buttons setting on the fly?). And 
as I said, I agree with Cristian that the real fix is just not supporting 
tooltips in the first place on buttons.

-- 
Martijn

[prev in list] [next in list] [prev in thread] [next in thread]