[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src
From:       Alexandre Pereira de Oliveira <aoliveira () kdemail ! net>
Date:       2005-08-31 23:36:27
Message-ID: 1125531387.843874.20206.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 455607 by aoliveira:

Revert bad commit.
TagLib::FileRef deletes the pointer on its dtor.
CCMAIL: possebaer@gmx.at


 M  +1 -4      metabundle.cpp  


--- trunk/extragear/multimedia/amarok/src/metabundle.cpp #455606:455607
@@ -161,11 +161,10 @@
     const QString path = m_url.path();
     TagLib::FileRef fileref;
     TagLib::Tag *tag = 0;
-    TagLib::MPEG::File *mpeg = 0;
 
     if( AmarokConfig::recodeID3v1Tags() && path.endsWith( ".mp3", false ) \
)  {
-        mpeg = new TagLib::MPEG::File( QFile::encodeName( path ), true, \
readStyle ); +        TagLib::MPEG::File *mpeg = new TagLib::MPEG::File( \
QFile::encodeName( path ), true, readStyle );  fileref = TagLib::FileRef( \
mpeg );  
         if( mpeg->isValid() )
@@ -199,8 +198,6 @@
         init( fileref.audioProperties() );
     }
 
-    delete mpeg;
-
     //FIXME disabled for beta4 as it's simpler to not got 100 bug reports
     //else if( KMimeType::findByUrl( m_url )->is( "audio" ) )
     //    init( KFileMetaInfo( m_url, QString::null, \
KFileMetaInfo::Everything ) );


[prev in list] [next in list] [prev in thread] [next in thread]