[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/kbabel_svn/catalogmanager/libcvs (silent)
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2005-08-31 23:13:50
Message-ID: 1125530030.453447.19664.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 455604 by goutte:

SVN_SILENT
Reading and saving the setting about CVS's encoding name does not work.


 M  +4 -0      cvsdialog.cpp  


--- branches/work/kbabel_svn/catalogmanager/libcvs/cvsdialog.cpp #455603:455604
@@ -115,7 +115,10 @@
     layout->addWidget( label );
     layout->addWidget( m_encodingComboBox );
     QStringList encodingList;
+#if 0
+    // ### FIXME: m_encoding is not initialzed correctly yet!
     encodingList << i18n( "Descriptive encoding name", "Last choice (%1)" ).arg( \
m_encoding ); +#endif
     encodingList << i18n( "Descriptive encoding name", "Recommended (%1)" ).arg( \
                "UTF-8" );
     encodingList << i18n( "Descriptive encoding name", "Locale (%1)" ).arg( \
QTextCodec::codecForLocale()->mimeName() );  encodingList += \
KGlobal::charsets()->descriptiveEncodingNames(); @@ -378,6 +381,7 @@
     if ( config->readBoolEntry( "PresetLastUsedMessage", false ) )
       logedit->setText( logMessages.first( ) );
 
+    // ### FIXME: that is called too late!
     m_encoding = config->readEntry( "CVSEncoding", "UTF-8" );
   }
 }


[prev in list] [next in list] [prev in thread] [next in thread]