[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kjs
From:       Luciano Montanaro <mikelima () cirulla ! net>
Date:       2005-08-30 17:57:48
Message-ID: 1125424668.939028.9235.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 455152 by montanaro:

No need to call regcomp twice in a row just to check for an error.


 M  +1 -1      regexp.cpp  


--- trunk/KDE/kdelibs/kjs/regexp.cpp #455151:455152
@@ -115,7 +115,7 @@
   // Note: the Global flag is already handled by RegExpProtoFunc::execute
 
   int errorCode = regcomp(&preg, intern.ascii(), regflags);
-  if (regcomp(&preg, intern.ascii(), regflags) != 0) {
+  if (errorCode != 0) {
 #ifndef NDEBUG
     char errorMessage[80];
     regerror(errorCode, &preg, errorMessage, sizeof errorMessage);
[prev in list] [next in list] [prev in thread] [next in thread]