[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdepim/libkcal
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2005-08-19 18:01:44
Message-ID: 1124474504.683021.26286.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 451010 by kainhofe:

It seems that gcc 4.0 is no longer initializing all members of a struct with 0, while \
gcc 3.3.x obviously did something like that. So we can't simply take a icaltime \
structure and assume its members are initalized to sane values. Rather, use a null \
time and set all fields later on.  I hope this fixes the end date corruption that \
vanRijn and and Will are observing with their gcc 4.0-compiled kdepim.


CCMAIL:wstephenson@kde.org


 M  +3 -3      icalformatimpl.cpp  


--- branches/KDE/3.5/kdepim/libkcal/icalformatimpl.cpp #451009:451010
@@ -1487,8 +1487,8 @@
   recur->setFrequency( r.interval );
 
   // Duration & End Date
-  icaltimetype t;
   if ( !icaltime_is_null_time( r.until ) ) {
+    icaltimetype t;
     t = r.until;
     // Convert to the correct time zone! it's in UTC by specification.
     QDateTime endDate( readICalDateTime(t) );
@@ -1701,7 +1701,7 @@
 
 icaltimetype ICalFormatImpl::writeICalDate(const QDate &date)
 {
-  icaltimetype t;
+  icaltimetype t = icaltime_null_time();
 
   t.year = date.year();
   t.month = date.month();
@@ -1722,7 +1722,7 @@
 
 icaltimetype ICalFormatImpl::writeICalDateTime(const QDateTime &datetime)
 {
-  icaltimetype t;
+  icaltimetype t = icaltime_null_time();
 
   t.year = datetime.date().year();
   t.month = datetime.date().month();


[prev in list] [next in list] [prev in thread] [next in thread]