From kde-commits  Tue Aug 16 16:05:06 2005
From: Andras Mantia <amantia () kdewebdev ! org>
Date: Tue, 16 Aug 2005 16:05:06 +0000
To: kde-commits
Subject: Re: branches/KDE/3.5/kdelibs/khtml
Message-Id: <200508161905.06776.amantia () kdewebdev ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=112420837600406
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart3499404.IhtRPr7fvy"

--nextPart3499404.IhtRPr7fvy
Content-Type: text/plain;
  charset="windows-1250"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 16 August 2005 19:36, David Faure wrote:
> On Tuesday 16 August 2005 12:13, Andras Mantia wrote:
> > > On Tuesday 16 August 2005 12.17, David Faure wrote:
> > >> > SVN commit 449438 by kling:
> > >> >
> > >> > Make sure there's a defaultHTMLSettings() around when fetching
> > >> > accessKeysEnabled setting. Should unbreak Quanta, as discussed
> > >> > on kfm-devel.
> > >>
> > >> Shouldn't this new+delete only be done when
> > >> defaultHTMLSettings() is 0?
> > >
> > > You are probably very right. :-)
> >
> > No, that would reintroduce the crash. defaultHTMLSettings() starts
> > with an "assert(s_self);". The whole KHTMLFactory class is strange
> > for me as it has static methods that cannot be called unless you
> > create an instance.
>
> OK, try
> KHTMLFactory::ref();
> ... defaultHTMLSettings() ...
> KHTMLFactory::deref();

::ref() and ::ref() is private, so one should use a "friend"=20
declaration. I suggested on kfm-devel to not do it that way.

Andras

=2D-=20
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org

--nextPart3499404.IhtRPr7fvy
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQBDAg6yTQdfac6L/08RAmVMAKCia3I36JHq3s6sX1Oen1WLkeh+zACfQHlm
DE5rBdTEB67QIXJLJ9Mff3c=
=Rc3e
-----END PGP SIGNATURE-----

--nextPart3499404.IhtRPr7fvy--