[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenox/konq-embed/dropin/kio
From:       Luciano Montanaro <mikelima () cirulla ! net>
Date:       2005-08-04 12:11:06
Message-ID: 1123157466.084944.5673.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 442917 by montanaro:

Silence a valgrind warning about jump over uninitialized memory.
Reordered the class members for a negligible amount of memory saving.


 M  +6 -5      krun.cpp  
 M  +1 -1      krun.h  


--- trunk/kdenox/konq-embed/dropin/kio/krun.cpp #442916:442917
@@ -21,6 +21,8 @@
 
 */
 
+#include <kdebug.h>
+
 #include "krun.h"
 
 #include "mimehandler.h"
@@ -42,14 +44,13 @@
 // ###
 #include <khtml_run.h>
 
-KRun::KRun( const KURL &url, int, bool, bool )
+KRun::KRun( const KURL &url, int, bool, bool ) : 
+	m_bFinished(false), m_fault(false), m_showingError(false), m_job(0), m_fhandle(-1)
 {
-    m_fault = false;
-    m_showingError = false;
     m_strURL = url;
     QTimer::singleShot( 0, this, SLOT( slotStart() ) );
-    m_job = 0;
-    m_fhandle = -1;
+    kdDebug(7010) << " new KRun " << this << " " << 
+                       url.prettyURL() << endl;
 }
 
 KRun::~KRun()
--- trunk/kdenox/konq-embed/dropin/kio/krun.h #442916:442917
@@ -32,9 +32,9 @@
     virtual void foundMimeType( const QString &type );
 
     KURL m_strURL;
-    bool m_bFinished;
     QTimer m_timer;
     KIO::Job *m_job;
+    bool m_bFinished;
     bool m_fault;
     bool m_showingError;
 
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic