[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src
From:       Max Howell <max.howell () methylblue ! com>
Date:       2005-07-25 13:38:15
Message-ID: 1122298695.708910.17008.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 438598 by mhowell:

The style guide fix previously now makes the button's purpose hard to decipher. I \
assume this change still conforms to the style guide (although I can't tell since the \
style fix was not explained), but it also makes more sense. I still prefer what it \
used to say so would enjoy an explanation for why "Perform Search..." is not \
acceptable.

Indeed I am confused about not using the "..." as the button leads to an interface \
that requires further input from the user. Thus the trailing ... should  be used, no?

 M  +1 -1      filebrowser.cpp  


--- trunk/extragear/multimedia/amarok/src/filebrowser.cpp #438597:438598
@@ -427,7 +427,7 @@
         connect( m_listView, SIGNAL(executed( QListViewItem* )), SLOT(activate( \
QListViewItem* )) );  }
 
-    KPushButton *button = new KPushButton( KGuiItem( i18n("Show Files Finder"), \
"find" ), this ); +    KPushButton *button = new KPushButton( KGuiItem( i18n("&Show \
Search Panel"), "find" ), this );  button->setToggleButton( true );
     connect( button, SIGNAL(toggled( bool )), SLOT(toggle( bool )) );
 


[prev in list] [next in list] [prev in thread] [next in thread]