[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.4/kdenetwork/kopete/protocols/msn
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-07-17 16:10:52
Message-ID: 1121616652.688348.17478.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 435607 by ogoffart:

Backport:  don't output the password in the debug



 M  +5 -4      msnsecureloginhandler.cpp  


--- branches/KDE/3.4/kdenetwork/kopete/protocols/msn/msnsecureloginhandler.cpp #435606:435607
@@ -32,7 +32,7 @@
 
 MSNSecureLoginHandler::~MSNSecureLoginHandler()
 {
-	kdDebug(14140) << k_funcinfo << endl;
+//	kdDebug(14140) << k_funcinfo << endl;
 }
 
 void MSNSecureLoginHandler::login()
@@ -77,7 +77,8 @@
 								",pwd=" + KURL::encode_string( m_password ) +
 								"," + m_authentification + "\r\n";
 
-		kdDebug(14140) << k_funcinfo << "Auth request: " << authRequest << endl;
+//   warning, this debug contains the password
+//		kdDebug(14140) << k_funcinfo << "Auth request: " << authRequest << endl;
 
 		authJob->addMetaData("customHTTPHeader", authRequest);
 		authJob->addMetaData("SendLanguageSettings", "false");
@@ -101,13 +102,13 @@
 	{
 		QString httpHeaders = authJob->queryMetaData("HTTP-Headers");
 
-		kdDebug(14140) << k_funcinfo << "HTTP headers: " << httpHeaders << endl;
+//		kdDebug(14140) << k_funcinfo << "HTTP headers: " << httpHeaders << endl;
 
 		QRegExp rx("from-PP='(.*)'");
 		rx.search(httpHeaders);
 		QString ticket = rx.cap(1);
 	
-		kdDebug(14140) << k_funcinfo << "Received ticket: " << ticket << endl;
+//		kdDebug(14140) << k_funcinfo << "Received ticket: " << ticket << endl;
 
 		emit loginSuccesful(ticket);
 	}
[prev in list] [next in list] [prev in thread] [next in thread]