[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kio/kio
From:       Kévin_Ottens <ervin () ipsquad ! net>
Date:       2005-07-15 9:43:22
Message-ID: 200507151143.28560.ervin () ipsquad ! net
[Download RAW message or body]


Le Vendredi 15 Juillet 2005 11:37, David Faure a écrit :
> I think you changed the behavior for setInteractive(false) jobs. Shouldn't
> the if() in slotWarning read
> if (isInteractive() && isAutoWarningHandlingEnabled())
> ?

Oh, right... my fault...

On the other hand, we shouldn't have used isInteractive() there in the first 
place. Maybe reintroducing it now, and adding a TODO for removing it for KDE4 
is a good compromise.

Regars.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]