[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegraphics/kpdf
From:       David Faure <faure () kde ! org>
Date:       2005-07-15 9:32:25
Message-ID: 200507151132.26112.faure () kde ! org
[Download RAW message or body]

On Thursday 14 July 2005 16:24, Dirk Mueller wrote:
> On Thursday 14 July 2005 13:32, Albert Astals Cid wrote:
> 
> > +if CXX_SUPPORTS_NOREGMOVE
> > +  # This fixes crash in Bug 109015 which i assume is a compiler bug
> > +  # as adding some correctly placed printf in
> > SplashOutputDev::convertPath() makes this +  # option unneeded
> > +  KDE_CXXFLAGS=-fno-regmove
> > +endif
> 
> please, don't. conditionalized variables have very poor support in 
> automake/am_edit. 

To avoid the automake conditional, use autoconf code like

if ...
  NOREGMOVE="-fno-regmove"
fi
AC_SUBST(NOREGMOVE)

and in Makefile.am
KDE_CXXFLAGS=$(NOREGMOVE)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]