[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/konqueror/keditbookmarks
From:       Daniel Teske <teske () squorn ! de>
Date:       2005-07-14 1:15:44
Message-ID: 1121303744.437102.24036.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 434422 by teske:

Another memory leak, this time in CmdGen::insertMimeSource



 M  +5 -0      commands.cpp  


--- trunk/KDE/kdebase/konqueror/keditbookmarks/commands.cpp #434421:434422
@@ -584,11 +584,16 @@
                 urlBks << KBookmark::standaloneBookmark(title, url, df.readIcon());
             }
             KBookmarkDrag *mydrag = KBookmarkDrag::newDrag(urlBks, 0);
+            modified = true;
             data = mydrag;
         }
     }
     if (!KBookmarkDrag::canDecode(data))
+    {
+        if (modified) // Shouldn't happen
+            delete data;
         return 0;
+    }
     KEBMacroCommand *mcmd = new KEBMacroCommand(cmdName);
     QString currentAddress = addr;
     QValueList<KBookmark> bookmarks = KBookmarkDrag::decode(data);
[prev in list] [next in list] [prev in thread] [next in thread]