[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    bugs/bugz
From:       Dirk Mueller <mueller () kde ! org>
Date:       2005-07-12 19:15:35
Message-ID: 1121195735.737212.11653.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 434053 by mueller:

more undefined warnings.. for some reason I get Carp::warn deep
recursions on them, but I can't fix that without upgrading perl on
ktown.. which I want to avoid :-)


 M  +2 -1      wizard.cgi  
 M  +2 -1      wizard_include.pl  


--- trunk/bugs/bugz/wizard.cgi #434052:434053
@@ -344,7 +344,8 @@
        || $vars->{'package'} eq 'konqueror/kjs' ) {
        $vars->{'khtml_message'} = 1;
     }
-    my @keywords = split(/\s+/, $::FORM{'keywords_text'});
+    my @keywords = ();
+    @keywords = split(/\s+/, $::FORM{'keywords_text'}) if (defined \
$::FORM{'keywords_text'});  if ( (scalar @keywords) < 4) {
        $vars->{'error'} = 1;
        $vars->{'compiler_text'} = $::FORM{'compiler_text'};
--- trunk/bugs/bugz/wizard_include.pl #434052:434053
@@ -214,7 +214,7 @@
     if ($app =~ m,^([^/]*)/(.*)$,) {
         SendSQL("SELECT description FROM components WHERE program = " . SqlQuote($1) \
. " AND value = " . SqlQuote($2) . ";");  $description = FetchOneColumn();
-	return ($description, $value) if ($description);
+	return ($description, $value) if (defined($description) and length($description));
 	$app = $1; # split of the component and try fallback
     }
 
@@ -223,6 +223,7 @@
     $description = FetchOneColumn();
     if (!$description) {
        # apparently this product doesn't exist.. try once more
+       $description = "";
        $value = "/";
        SendSQL("SELECT description, program, value FROM components WHERE value = " . \
SqlQuote($app) . ";");  ($description, $value, $app) = FetchSQLData();


[prev in list] [next in list] [prev in thread] [next in thread]