[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdecore/tests
From:       Nadeem Hasan <nhasan () nadmm ! com>
Date:       2005-07-09 3:28:06
Message-ID: 200507082328.06577.nhasan () nadmm ! com
[Download RAW message or body]

On Friday 08 July 2005 11:25 pm, Ameet Bagga wrote:
> On Friday 08 July 2005 11:42 pm, Shaheed wrote:
> > David,
> >
> > Thanks for the test. The bulk of the "problems" are expected: they are
> > the consequence of trying to support all the logic that the original
> > code I scoured had, but eliminating the platform #ifdef's where I
> > could.
>
> The question is why did this code make it into kdelibs without first
> going through these basic tests? The initial commit was also pretty rough
> code-wise which David also fixed. Maybe I missed it, but was this code
> ever peer reviewed on core-devel before being committed?

Its me btw....sorry for the confusion...kmail was using my wife's profile ;)
[prev in list] [next in list] [prev in thread] [next in thread]