[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/security/pwmanager/pwmanager
From:       Michael Buesch <mbuesch () freenet ! de>
Date:       2005-06-30 20:53:49
Message-ID: 200506302253.49533.mbuesch () freenet ! de
[Download RAW message or body]


Quoting Dirk Mueller <mueller@kde.org>:
> On Wednesday 29 June 2005 22:33, Michael Buesch wrote:
> 
> > > +INCLUDES = -I$(srcdir)/libpwmanager/ $(all_includes)
> > I would prefer to fix this in another way.
> > What was the actual error message you got?
> 
> its standard problem if you do incremental compilation and there are 
> incompatible changes in the libs. in this case it has to use the header files 
> from the source dir and not the installed ones. 
> 
> This is the recommended way to fix it and its done this way throughout all of 
> KDE. If you want to fix it in another way it would be inconsistent and quite 
> likely get reverted at some point in the future. 

eh, nono. You don't understand.
libpwmanager is part of the pwmanager sources. You can not
compile libpwmanager standalone. In fact libpwmanager is
in a subdirectory of the pwmanager sources.

If I do in the sources:
#include "libpwmanager/foobar.h"
It works. I cannot see how this would grab the installed header.
I guess this was some error message which came from an
#include "pwmexception.h"
or
#include "globalstuff.h"
which I recently moved to the libpwmanager dir. The correct fix
would be to prepend "libpwmanager/" in the include path.

So I would like to see the error message he got.
BTW: This is exactly the reason I always include the
gcc error in the commit messages, if I do such fixes.

-- 
Greetings, Michael



[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]