[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.4/kdebase/konqueror/listview
From:       David Faure <faure () kde ! org>
Date:       2005-06-17 18:19:02
Message-ID: 1119032342.924146.31006.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 426572 by dfaure:

Fix crashes in tooltip and preview code due to dangling KFileItems after
a reload, or a file gets deleted/moved. Thanks to Maks for his bug report
handling, merging, patch testing, and for reminding me to fix this :)
BUG: 100800
BUG: 96405


 M  +6 -0      konq_listviewwidget.cc  


--- branches/KDE/3.4/kdebase/konqueror/listview/konq_listviewwidget.cc #426571:426572
@@ -1127,6 +1127,7 @@
    //kdDebug(1202) << k_funcinfo << endl;
 
    m_activeItem = 0;
+   m_fileTip->setItem( 0 );
    delete m_selected; m_selected = 0;
    m_pBrowserView->resetCount();
    m_pBrowserView->lstPendingMimeIconItems().clear();
@@ -1180,6 +1181,11 @@
       m_pBrowserView->deleteItem( _fileitem );
       m_pBrowserView->lstPendingMimeIconItems().remove( &(*it) );
 
+      if ( m_activeItem == &(*it) ) {
+          m_fileTip->setItem( 0 );
+          m_activeItem = 0;
+      }
+
       delete &(*it);
       // HACK HACK HACK: QListViewItem/KonqBaseListViewItem should
       // take care and the source looks like it does; till the
[prev in list] [next in list] [prev in thread] [next in thread]