[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.4/kdelibs/kdeui
From:       Maks Orlovich <maksim () kde ! org>
Date:       2005-06-14 19:54:39
Message-ID: 1118778879.327577.19636.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 425455 by orlovich:

Do not let the idle buttons list hold dead buttons when calling QToolBar::clear, as that will 
delete them, causing a mess.

I would appreciate if someone could forward-port to 3.5

Fixes #105164, might also fix #101188, but I can't reproduce that well enough to be sure. 
BUG:105164
CCBUG:101188



 M  +5 -0      ktoolbar.cpp  


--- branches/KDE/3.4/kdelibs/kdeui/ktoolbar.cpp #425454:425455
@@ -664,6 +664,11 @@
 
 void KToolBar::clear ()
 {
+    /* Delete any idle buttons, so QToolBar doesn't delete them itself, making a mess */
+    for(QWidget *w=d->idleButtons.first(); w; w=d->idleButtons.next())
+       w->blockSignals(false);    
+    d->idleButtons.clear();
+     
     QToolBar::clear();
     widget2id.clear();
     id2widget.clear();
[prev in list] [next in list] [prev in thread] [next in thread]