[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/kicker
From:       Barış_Metin <baris () uludag ! org ! tr>
Date:       2005-06-05 11:02:21
Message-ID: 200506051402.24629.baris () uludag ! org ! tr
[Download RAW message or body]


On Saturday 04 June 2005 20:19, André Wöbbeking wrote:
> On Saturday 04 June 2005 00:07, Barış Metin wrote:
> > SVN commit 421769 by baris:
> >
> > - Makes the clock applet use KickerTip
> > - Adds a new updateKickerTip() function to kickertip
>
> really nice :-) But you should
> 1) remove the now obsolete QToolTip (it's somehow possible to get the
> old one)

KickerTip disables and enables QToolTip depending on the users settings. Did I 
got your commet wrong?

> 2) use formatDateTime() if you display time and date in one line (could
> matter for RTL languages)

Yes. But I've some feeling that we'll change the way it looks in some time 
soon. I don't know if the current appearing of the tip is the best it can :).

> 3) not use _prefs->plainShowSeconds() as parameter for formatDate()

You see copy&paste is not a good habit while coding :). Fixed it. Thank you.

regards,
-- 
Barış Metin

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]