[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/kde4/kdelibs/kdecore
From:       Richard Smith <richard () metafoo ! co ! uk>
Date:       2005-05-26 8:47:33
Message-ID: 200505260947.34985.richard () metafoo ! co ! uk
[Download RAW message or body]

On Wednesday 25 May 2005 12:49, Laurent Montel wrote:
> SVN commit 418051 by mlaurent:
>
> Warning --
>
>
>  M  +2 -2      kiconeffect.cpp
>
>
> --- branches/work/kde4/kdelibs/kdecore/kiconeffect.cpp #418050:418051
> @@ -312,7 +312,7 @@
>
>
>      int rval, gval, bval, val, alpha, i;

Should probably remove the variable i from here.

> -    for (i=0; i<ii.pixels; i++)
> +    for (unsigned int i=0; i<ii.pixels; i++)
>      {
>  	val = qGray(data[i]);
>  	alpha = qAlpha(data[i]);
> @@ -335,7 +335,7 @@
>
>      int rval, gval, bval, val, alpha, i;

Here too.

>      float rcol = col.red(), gcol = col.green(), bcol = col.blue();
> -    for (i=0; i<ii.pixels; i++)
> +    for (unsigned int i=0; i<ii.pixels; i++)
>      {
>          val = qGray(data[i]);
>          if (val < 128)
[prev in list] [next in list] [prev in thread] [next in thread]