[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: kdebase/kicker/core
From: Gábor_Lehel <illissius () gmail ! com>
Date: 2005-05-15 15:46:22
Message-ID: 9cfeadb8050515084646c39831 () mail ! gmail ! com
[Download RAW message or body]
here you go ;). it's odd how I barely wrote anything that actually
does stuff, and yet, it does stuff... (I suppose that's the KConfigXT
magic at work? :).
and semirelated, I have another idea wrt the whole
applet-handles-are-ugly-but-you-can't-move-applets-without-them
conundrum -- move the "hide applet handles" option from way back
hidden in the advanced options in kcontrol, into the panel's context
menu, and call it something like "lock panel", a la winxp (and make it
prevent moving buttons as well, for completeness's sake).
On 5/8/05, Aaron J. Seigo <aseigo@kde.org> wrote:
> On Sunday 08 May 2005 10:42, Gábor Lehel wrote:
> > either (I assume conflicts between the text and background color is
> > what you meant by 'annoyance'? or something else?).
>
> yes, with no good way of controlling it due to how the menubar is grabbed from
> the app window.
>
> > I don't quite know what you're referring to re: background tiles...
> > what are they, and is there any way I could use them to recreate my
> > previous configuration?
>
> not really. one could add a special entry into kicker_menubarpanelrc to
> control this, i suppose. patches welcome.
>
> --
> Aaron J. Seigo
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
>
>
--
Work is punishment for failing to procrastinate effectively.
["transparentmenubarpanel.patch" (text/x-diff)]
Index: kcontrol/kicker/advancedOptions.ui
===================================================================
--- kcontrol/kicker/advancedOptions.ui (revision 414214)
+++ kcontrol/kicker/advancedOptions.ui (working copy)
@@ -12,6 +12,9 @@
<height>235</height>
</rect>
</property>
+ <property name="caption">
+ <string>advancedKickerOptions</string>
+ </property>
<vbox>
<property name="name">
<cstring>unnamed</cstring>
@@ -184,7 +187,7 @@
<string>Click on this button to set the color to \
use when tinting transparent panels.</string> </property>
</widget>
- <spacer row="2" column="0" rowspan="2" colspan="1">
+ <spacer row="2" column="0">
<property name="name">
<cstring>spacer2</cstring>
</property>
@@ -201,7 +204,7 @@
</size>
</property>
</spacer>
- <widget class="QLabel" row="3" column="1">
+ <widget class="QLabel" row="2" column="1">
<property name="name">
<cstring>textLabel3</cstring>
</property>
@@ -232,7 +235,7 @@
</size>
</property>
</spacer>
- <widget class="QSlider" row="1" column="1" rowspan="2" \
colspan="2"> + <widget class="QSlider" row="1" column="1" \
rowspan="1" colspan="2"> <property name="name">
<cstring>tintSlider</cstring>
</property>
@@ -243,7 +246,7 @@
<string>Use this slider to set how much \
transparent panels should be tinted using the tint color.</string> \
</property> </widget>
- <widget class="QLabel" row="3" column="2">
+ <widget class="QLabel" row="2" column="2">
<property name="name">
<cstring>textLabel2</cstring>
</property>
@@ -285,6 +288,17 @@
<string>Click on this button to set the color to \
use when tinting transparent panels.</string> </property>
</widget>
+ <widget class="QCheckBox" row="3" column="0" rowspan="1" \
colspan="2"> + <property name="name">
+ <cstring>menubarPanelTransparent</cstring>
+ </property>
+ <property name="text">
+ <string>Also apply to panel with menu bar</string>
+ </property>
+ <property name="whatsThis" stdset="0">
+ <string>Normally if you have the desktop's or \
current application's menu bar displayed in a panel at the top of the \
screen (MacOS-style), transparency is disabled for this panel to avoid the \
desktop background clashing with the menu bar. Set this option to make it \
transparent anyways.</string> + </property>
+ </widget>
</grid>
</widget>
</vbox>
Index: kcontrol/kicker/advancedDialog.cpp
===================================================================
--- kcontrol/kicker/advancedDialog.cpp (revision 414214)
+++ kcontrol/kicker/advancedDialog.cpp (working copy)
@@ -61,6 +61,8 @@
this, SLOT(changed()));
connect(m_advancedWidget->tintSlider, SIGNAL(valueChanged(int)),
this, SLOT(changed()));
+ connect(m_advancedWidget->menubarPanelTransparent, SIGNAL(clicked()),
+ this, SLOT(changed()));
load();
}
@@ -88,6 +90,9 @@
m_advancedWidget->tintColorB->setColor( color );
int tintValue = c.readNumEntry( "TintValue", 0 );
m_advancedWidget->tintSlider->setValue( tintValue );
+
+ bool transparentMenubarPanel = \
c.readBoolEntry("MenubarPanelTransparent", false); + \
m_advancedWidget->menubarPanelTransparent->setChecked( \
transparentMenubarPanel );
enableButtonApply(false);
}
@@ -107,6 +112,8 @@
m_advancedWidget->tintColorB->color());
c.writeEntry("TintValue",
m_advancedWidget->tintSlider->value());
+ c.writeEntry("MenubarPanelTransparent",
+ m_advancedWidget->menubarPanelTransparent->isChecked());
QStringList elist = c.readListEntry("Extensions2");
for (QStringList::Iterator it = elist.begin(); it != elist.end(); \
++it) @@ -135,6 +142,8 @@
m_advancedWidget->tintColorB->color());
extConfig.writeEntry("TintValue",
m_advancedWidget->tintSlider->value());
+ extConfig.writeEntry("MenubarPanelTransparent",
+ \
m_advancedWidget->menubarPanelTransparent->isChecked());
extConfig.sync();
}
Index: kicker/core/containerarea.cpp
===================================================================
--- kicker/core/containerarea.cpp (revision 414214)
+++ kicker/core/containerarea.cpp (working copy)
@@ -1264,7 +1264,8 @@
_bgSet = false;
if (KickerSettings::transparent() &&
- !ExtensionManager::the()->isMenuBar(topLevelWidget()))
+ (KickerSettings::menubarPanelTransparent() ||
+ !ExtensionManager::the()->isMenuBar(topLevelWidget())))
{
if ( !_rootPixmap )
{
Index: kicker/share/kickerSettings.kcfg
===================================================================
--- kicker/share/kickerSettings.kcfg (revision 414214)
+++ kicker/share/kickerSettings.kcfg (working copy)
@@ -20,6 +20,12 @@
<default>false</default>
</entry>
+<entry name="MenubarPanelTransparent" type="Bool" >
+ <label>Enable transparency for menubar panel</label>
+ <whatsthis>When this option is enabled, the panel containing the \
menubar will become pseudo-transparent as well</whatsthis> + \
<default>false</default> + </entry>
+
<entry name="UseBackgroundTheme" type="Bool" >
<label>Enable background image</label>
<whatsthis>When this option is enabled, the panel will display a \
tiled image as its background</whatsthis>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic