[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/tools/kfile-plugins/ooo
From:       Laurent Montel <montel () kde ! org>
Date:       2005-05-15 9:43:35
Message-ID: 1116150215.464129.8304.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 414082 by mlaurent:

Add some const


 M  +4 -4      trunk/koffice/tools/kfile-plugins/ooo/kfile_ooo.cpp  
 M  +5 -5      trunk/koffice/tools/kfile-plugins/ooo/kfile_ooo.h  


--- trunk/koffice/tools/kfile-plugins/ooo/kfile_ooo.cpp #414081:414082
@@ -343,13 +343,13 @@
     return true;
 }
 
-QString KOfficePlugin::stringFromNode(QDomNode node, QString name)
+QString KOfficePlugin::stringFromNode(const QDomNode &node, const QString &name)
 {
     QString value = node.namedItem(name).toElement().text();
     return value.isEmpty() ? QString::null : value;
 }
 
-void KOfficePlugin::addAttributeInfo(const QDomElement & elem, KFileMetaInfoGroup & \
group, const QString attributeName) +void KOfficePlugin::addAttributeInfo(const \
QDomElement & elem, KFileMetaInfoGroup & group, const QString &attributeName)  {
   if (!elem.hasAttribute(attributeName)){
   	return;
@@ -362,8 +362,8 @@
 
 bool KOfficePlugin::writeTextNode(QDomDocument & doc,
 				  QDomNode & parentNode,
-				  const QString  nodeName,
-				  const QString  value) const
+				  const QString  &nodeName,
+				  const QString  &value) const
 {
   if (parentNode.toElement().isNull()){
     kdDebug(7034) << "Parent node is Null or not an Element, cannot write node "
--- trunk/koffice/tools/kfile-plugins/ooo/kfile_ooo.h #414081:414082
@@ -31,7 +31,7 @@
 class KOfficePlugin: public KFilePlugin
 {
     Q_OBJECT
-    
+
 public:
     /**
      * Constructor */
@@ -59,17 +59,17 @@
 private:
     bool writeTextNode(QDomDocument & doc,
 		       QDomNode & parentNode,
-		       const QString  nodeName,
-		       const QString  value) const;
+		       const QString  &nodeName,
+		       const QString  &value) const;
     KFileMimeTypeInfo::GroupInfo* userdefined;
     void addAttributeInfo(const QDomElement & elem, KFileMetaInfoGroup & group,
-		          const QString attributeName);
+		          const QString &attributeName);
     QIODevice* getData(KArchive &m_zip, int fileMode) const;
     bool writeMetaData(const QString & path, const QDomDocument &doc) const;
     QDomDocument getMetaDocument(const QString &path) const;
     QDomNode getBaseNode(const QDomDocument &doc) const;
     void makeMimeTypeInfo(const QString& mimeType);
-    QString stringFromNode(QDomNode node, QString name);
+    QString stringFromNode(const QDomNode &node, const QString &name);
     void getEditingTime(KFileMetaInfoGroup group1, const char *, QString & txt);
     void getDateTime(KFileMetaInfoGroup group1, const char *, QString & txt);
 };


[prev in list] [next in list] [prev in thread] [next in thread]