[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdesdk/scripts
From:       Michael Pyne <michael.pyne () kdemail ! net>
Date:       2005-05-15 5:54:47
Message-ID: 1116136487.992814.3464.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 414019 by mpyne:

And in this instance, Perl did do what I meant, except when kdesvn-build was
running on Thiago's system.  So, change 'unless scalar @dirs' to the
wordier 'if scalar @dirs == 0', and change the while loop into a for loop.

Actually this change restores this part of the code to the way it was before
the apidox patch, where I was experimenting with do { ... } while and gave it
up when Perl told me that it wasn't really a loop, and I didn't undo my changes
*exactly*, which broke kdesvn-build elsewhere (but not here for some reason).


 M  +2 -2      trunk/KDE/kdesdk/scripts/kdesvn-build  


--- trunk/KDE/kdesdk/scripts/kdesvn-build #414018:414019
@@ -654,8 +654,8 @@
         print "\t$description...\n";
     }
 
-    push (@dirs, "") unless scalar @dirs;
-    while (my $subdir = shift @dirs)
+    push (@dirs, "") if scalar @dirs == 0;
+    for my $subdir (@dirs)
     {
         # Some subdirectories shouldn't have make run within them.
         next unless is_subdir_buildable($module, $subdir);
[prev in list] [next in list] [prev in thread] [next in thread]