[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/filters/kspread/csv
From:       Raphael Langerhorst <raphael-langerhorst () gmx ! at>
Date:       2005-05-09 8:43:34
Message-ID: 1115628214.139865.1525.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 411416 by raphael:

Fix CSV import and use generic format for imported "Text" columns.

BUG: 105179

Thanks go to my brother Michael for actually detecting the bug.
CCMAIL: Michael.Langerhorst@fh-steyr.at



 M  +12 -0     trunk/koffice/filters/kspread/csv/csvimport.cc  


--- trunk/koffice/filters/kspread/csv/csvimport.cc #411415:411416
@@ -151,8 +151,20 @@
             switch (dialog->getHeader(col))
             {
              case CSVDialog::TEXT:
+               //see KSpreadCSVDialog::accept(), Tomas introduced the Generic format \
between KOffice 1.3 and 1.4 +               //the Insert->External Data-> ... dialog \
uses the generic format for everything (see mentioned method) +               //I \
will use this approach only for the TEXT format in the CSV import filter... (raphael) \
+               //### FIXME: long term solution is to allow to select Generic format \
("autodetect") in the dialog and make it the default +               
+               cell = sheet->nonDefaultCell( col + 1, row + 1, false, s );
+               cell->setCellText( text );
+               
+               cell->setFormatType (Generic_format);
+               
+               /* old code
               cell = sheet->nonDefaultCell( col + 1, row + 1, false, s );
               cell->setCellText( text, true );
+               */
               break;
              // ### TODO: put the code for the different numbers together (at least \
partially)  case CSVDialog::NUMBER:


[prev in list] [next in list] [prev in thread] [next in thread]