[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/khtml
From:       Rob Buis <rwlbuis () xs4all ! nl>
Date:       2005-05-07 13:55:35
Message-ID: 20050507135535.GA35554 () xs4all ! nl
[Download RAW message or body]

Hi Harri,

Thanks a lot! I kind of forgot about this one.
Just a small nitpick, the bug report number seems wrong?
Cheers,

Rob.

On Sat, May 07, 2005 at 01:50:00PM +0000, Harri Porten wrote:
> SVN commit 410300 by porten:
> 
> implemented HTMLTableCellElementImpl::cellIndex() in the way suggested
> by Rob.
> 
> BUGS:7690
> 
> 
>  M  +3 -0      trunk/KDE/kdelibs/khtml/ChangeLog  
>  M  +5 -0      trunk/KDE/kdelibs/khtml/html/html_tableimpl.cpp  
>  M  +1 -2      trunk/KDE/kdelibs/khtml/html/html_tableimpl.h  
> 
> 
> --- trunk/KDE/kdelibs/khtml/ChangeLog #410299:410300
> @@ -1,5 +1,8 @@
>  2005-05-07  Harri Porten  <porten@kde.org>
>  
> +	* html/html_tableimpl.cpp (cellIndex): return meaningful values
> +	using patch suggested by Rob in bug report #7690.
> +
>  	* ecma/kjs_window.cpp: allow setting location.href on foreign
>  	windows opened by window.open() again (bug #101178).
>  
> --- trunk/KDE/kdelibs/khtml/html/html_tableimpl.cpp #410299:410300
> @@ -766,6 +766,11 @@
>  {
>  }
>  
> +long HTMLTableCellElementImpl::cellIndex() const
> +{
> +    return nodeIndex();
> +}
> +
>  void HTMLTableCellElementImpl::parseAttribute(AttributeImpl *attr)
>  {
>      switch(attr->id())
> --- trunk/KDE/kdelibs/khtml/html/html_tableimpl.h #410299:410300
> @@ -177,8 +177,7 @@
>      HTMLTableCellElementImpl(DocumentPtr *doc, int tagId);
>      ~HTMLTableCellElementImpl();
>  
> -    // ### FIX these two...
> -    long cellIndex() const { return 0; }
> +    long cellIndex() const;
>  
>      int col() const { return _col; }
>      void setCol(int col) { _col = col; }
[prev in list] [next in list] [prev in thread] [next in thread]