[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdeextragear-3
From:       Dirk Mueller <mueller () kde ! org>
Date:       2005-05-01 14:02:27
Message-ID: 20050501140227.90B79681 () office ! kde ! org
[Download RAW message or body]

CVS commit by mueller: 

- don't reinvent your configure checks
- don't hardcode -Wall, use --enable-warnings


  M +1 -0      configure.in.in   1.10
  M +1 -12     pwmanager/Makefile.flags   1.6
  M +0 -18     pwmanager/configure.in.in   1.11


--- kdeextragear-3/configure.in.in  #1.9:1.10
@@ -1,3 +1,4 @@
 #MIN_CONFIG(3.1)
+KDE_ENABLE_HIDDEN_VISIBILITY
 
 KDE_INIT_DOXYGEN([The API Reference], [Version $VERSION])

--- kdeextragear-3/pwmanager/Makefile.flags  #1.5:1.6
@@ -2,18 +2,7 @@
 
 KDE_CXXFLAGS = -DQT_NO_STL -DQT_NO_COMPAT -DQT_CLEAN_NAMESPACE \
-               -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -Wall \
-               -Wformat-security
+               -D_GNU_SOURCE -D__STDC_LIMIT_MACROS
 
 if COND_DEBUG
 KDE_CXXFLAGS += -O0 -fno-omit-frame-pointer -pedantic
-
-endif
-
-if COND_PWMANAGER_GCC_VISIBILITY
-#TODO: first mark necessary symbols in source as PWM_EXPORT
-#KDE_CXXFLAGS += -fvisibility=hidden
 endif
-if COND_PWMANAGER_GCC_HIDDENINLINES
-KDE_CXXFLAGS += -fvisibility-inlines-hidden
-endif
-

--- kdeextragear-3/pwmanager/configure.in.in  #1.10:1.11
@@ -189,20 +189,2 @@
                AC_DEFINE(LITTLE_ENDIAN_HOST, 1, [little-endian]),
                AC_DEFINE(LITTLE_ENDIAN_HOST, 1, [little-endian]))
-
-dnl check for available compiler flags
-pwmanager_have_gcc_visibility="no"
-KDE_CHECK_COMPILER_FLAG([fvisibility=hidden],
-                        pwmanager_have_gcc_visibility="yes",
-                        pwmanager_have_gcc_visibility="no")
-AM_CONDITIONAL(COND_PWMANAGER_GCC_VISIBILITY, [test "$pwmanager_have_gcc_visibility" = "yes"])
-if test "$pwmanager_have_gcc_visibility" = "yes"; then
-        AC_DEFINE(CONFIG_PWMANAGER_GCC_VISIBILITY, 1, [gcc -fvisibilty support])
-fi
-pwmanager_have_gcc_hiddeninlines="no"
-KDE_CHECK_COMPILER_FLAG(fvisibility-inlines-hidden,
-                        pwmanager_have_gcc_hiddeninlines="yes",
-                        pwmanager_have_gcc_hiddeninlines="no")
-AM_CONDITIONAL(COND_PWMANAGER_GCC_HIDDENINLINES, [test "$pwmanager_have_gcc_hiddeninlines" = "yes"])
-if test "$pwmanager_have_gcc_hiddeninlines" = "yes"; then
-        AC_DEFINE(CONFIG_PWMANAGER_GCC_HIDDENINLINES, 1, [gcc -fvisibility-inlines-hidden support])
-fi


[prev in list] [next in list] [prev in thread] [next in thread]