[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdenonbeta/ksvg2/impl
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2005-05-01 1:12:26
Message-ID: 20050501011226.AD86A667 () office ! kde ! org
[Download RAW message or body]

CVS commit by wildfox: 

Found a rather heavy bug which leads to endless loops:
-> KSVG::SVGLinearGradientElementImpl::buildGradient
 -> KSVG::SVGGradientElementImpl::notifyAttributeChange
  -> KSVG::SVGList<KSVG::SVGTransformImpl>::appendItem
   -> KDOM::DOMList<KSVG::SVGTransformImpl>::initialize
    -> KSVG::SVGTransformListImpl::consolidate
     -> KSVG::SVGLinearGradientElementImpl::buildGradient
...

CCMAIL: buis@kde.org


  M +8 -1      SVGTransformListImpl.cc   1.4


--- kdenonbeta/ksvg2/impl/SVGTransformListImpl.cc  #1.3:1.4
@@ -48,5 +48,12 @@ SVGTransformImpl *SVGTransformListImpl::
                 return 0;
 
-        return initialize(obj);
+        // Disable notifications here...
+        const SVGStyledElementImpl *savedContext = m_context;
+
+        m_context = 0;
+        SVGTransformImpl *ret = initialize(obj);
+        m_context = savedContext;
+        
+        return ret;
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]