[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kicker/taskmanager (silent)
From:       Maks Orlovich <mo85 () cornell ! edu>
Date:       2005-04-30 14:22:25
Message-ID: 200504301022.25439.mo85 () cornell ! edu
[Download RAW message or body]

On Saturday 30 April 2005 03:00 am, Stefan Nikolaus wrote:
> CVS commit by nikolaus:
>
> CVS_SILENT
>
> comparison in findTask()


This seems to be wrong. If the iterator == end(), it's not pointing to any 
valid data.

-Maksim

>
>
>   M +1 -1      taskmanager.cpp   1.108
>
>
> --- kdebase/kicker/taskmanager/taskmanager.cpp  #1.107:1.108
> @@ -212,5 +212,5 @@ Task::Ptr TaskManager::findTask(WId w)
>      Task::Dict::iterator itEnd = m_tasksByWId.end();
>
> -    if (it != itEnd)
> +    if (it == itEnd)
>      {
>          return it.data();
[prev in list] [next in list] [prev in thread] [next in thread]