[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdemultimedia/kioslave/audiocd
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2005-04-30 13:31:20
Message-ID: 20050430133120.8782F665 () office ! kde ! org
[Download RAW message or body]

CVS commit by cullmann: 

make max_retries configurable in the config file, gui still missing
default up to 20, like in the command line app, really, 5 is too low, get here
massive errors on both machines ;)


  M +7 -4      audiocd.cpp   1.140


--- kdemultimedia/kioslave/audiocd/audiocd.cpp  #1.139:1.140
@@ -263,4 +263,5 @@ public:
         QString device; // URL settable
         int paranoiaLevel; // URL settable
+        int retryLimit;
 
         // Directory strings, never change after init
@@ -985,6 +986,6 @@ void AudioCDProtocol::paranoiaRead(
         while (currentSector <= lastSector)
         {
-                // TODO make the 5 configurable? The default in the lib is 20 fyi
-                int16_t * buf = paranoia_read_limited(paranoia, paranoiaCallback, 5);
+                // TODO: retry limit read out of config file, GUI MISSING
+                int16_t * buf = paranoia_read_limited(paranoia, paranoiaCallback, d->retryLimit);
                 if( warned == 0 && paranoia_read_limited_error >= 5 ){
 #if KDE_IS_VERSION (3, 2, 89)
@@ -1157,4 +1158,6 @@ void AudioCDProtocol::loadSettings()
         }
 
+        d->retryLimit = config->readNumEntry("max_retries", 20);
+
         if(config->hasKey("niceLevel")) {
                 int niceLevel = config->readNumEntry("niceLevel", 0);


[prev in list] [next in list] [prev in thread] [next in thread]