[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/kjs
From:       Harri Porten <porten () kde ! org>
Date:       2005-04-24 10:37:53
Message-ID: 20050424103753.BB93E3C8 () office ! kde ! org
[Download RAW message or body]

CVS commit by porten: 

let's see how often this is triggered. I think the current implementation
does not give the expected results.


  M +7 -0      ustring.cpp   1.70


--- kdelibs/kjs/ustring.cpp  #1.69:1.70
@@ -900,4 +900,11 @@ bool KJS::operator==(const UString& s1, 
     return false;
 
+#ifndef NDEBUG
+  if ((s1.isNull() && s2.isEmpty() && !s2.isNull()) ||
+      (s2.isNull() && s1.isEmpty() && !s1.isNull()))
+    fprintf(stderr,
+            "KJS warning: comparison between empty and null string\n");
+#endif
+
   return (memcmp(s1.rep->dat, s2.rep->dat,
                  s1.rep->len * sizeof(UChar)) == 0);


[prev in list] [next in list] [prev in thread] [next in thread]